New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22484][table] Add built-in MAP_KEYS, MAP_VALUES, MAP_FROM_ARRA… #15797
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit dd83582 (Fri May 28 11:09:16 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @snuyanzin. Let me know if you have questions.
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java
Outdated
Show resolved
Hide resolved
...-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/table/types/inference/strategies/MapFromArraysInputTypeStrategy.java
Outdated
Show resolved
Hide resolved
...er-blink/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
Outdated
Show resolved
Hide resolved
...-blink/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
Outdated
Show resolved
Hide resolved
...-blink/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
Outdated
Show resolved
Hide resolved
...ink/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromArraysFunction.java
Outdated
Show resolved
Hide resolved
...ink/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromArraysFunction.java
Outdated
Show resolved
Hide resolved
...ink/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromArraysFunction.java
Outdated
Show resolved
Hide resolved
...ink/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromArraysFunction.java
Outdated
Show resolved
Hide resolved
@snuyanzin Does it make sense to restart/rework this PR? |
several times i felt lack of that feature... |
@snuyanzin do you rework it again. if you do not have time,I can do it |
dd83582
to
94c57a0
Compare
...-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
Show resolved
Hide resolved
@MartijnVisser (I tag you since you've recently asked about this) |
...main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java
Show resolved
Hide resolved
...lanner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
Outdated
Show resolved
Hide resolved
...lanner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
Outdated
Show resolved
Hide resolved
It looks good to me. and i left one minor comments |
…map_keys and map_values
rebased to resolve conflicts |
What is the purpose of the change
The PR implements three functions from the list mentioned in FLINK-22484 :
MAP_KEYS
,MAP_VALUES
,MAP_FROM_ARRAYS
Brief change log
Implementation, tests and docs for
MAP_KEYS
,MAP_VALUES
,MAP_FROM_ARRAYS
Verifying this change
This change added tests and can be verified as follows:
CollectionFunctionsITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation