Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22484][table] Add built-in MAP_KEYS, MAP_VALUES, MAP_FROM_ARRA… #15797

Merged
merged 9 commits into from Mar 16, 2023

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

The PR implements three functions from the list mentioned in FLINK-22484 : MAP_KEYS, MAP_VALUES, MAP_FROM_ARRAYS

Brief change log

Implementation, tests and docs for MAP_KEYS, MAP_VALUES, MAP_FROM_ARRAYS

Verifying this change

This change added tests and can be verified as follows:

  • CollectionFunctionsITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs / JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 28, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit dd83582 (Fri May 28 11:09:16 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 28, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @snuyanzin. Let me know if you have questions.

@snuyanzin snuyanzin requested a review from twalthr May 6, 2021 12:11
@MartijnVisser
Copy link
Contributor

@snuyanzin Does it make sense to restart/rework this PR?

@snuyanzin
Copy link
Contributor Author

several times i felt lack of that feature...
probably you're right i should give it another chance

@liuyongvs
Copy link
Contributor

@snuyanzin do you rework it again. if you do not have time,I can do it

@snuyanzin
Copy link
Contributor Author

@MartijnVisser (I tag you since you've recently asked about this)
the PR is rebased, let's wait for the feedback

@liuyongvs
Copy link
Contributor

It looks good to me. and i left one minor comments

@snuyanzin
Copy link
Contributor Author

rebased to resolve conflicts

@snuyanzin snuyanzin merged commit e42d708 into apache:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants