Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22253][docs] Update back pressure monitoring docs with new WebUI changes #15811

Merged
merged 2 commits into from May 4, 2021

Conversation

pnowojski
Copy link
Contributor

This PR updates the docs to reflect changes implemented in https://issues.apache.org/jira/browse/FLINK-14712

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 29, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8cd8179 (Fri May 28 11:07:56 UTC 2021)

Warnings:

  • Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanations are clear, I simply created some suggestions for improving the English.

One question though: does the timeout work as stated? I remember we discussed with Roman doing this a bit differently.

docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/monitoring/back_pressure.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/checkpoints.md Outdated Show resolved Hide resolved
@pnowojski
Copy link
Contributor Author

Thanks for the suggestions @alpinegizmo! Yes, uc timeout is counted against subtask's alignment time.

Copy link
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this now, but I've added one last (trivial) suggestion.

@pnowojski
Copy link
Contributor Author

Thanks a lot! I've included that last one suggestion and I'm going to merge it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants