New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22253][docs] Update back pressure monitoring docs with new WebUI changes #15811
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8cd8179 (Fri May 28 11:07:56 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanations are clear, I simply created some suggestions for improving the English.
One question though: does the timeout work as stated? I remember we discussed with Roman doing this a bit differently.
Thanks for the suggestions @alpinegizmo! Yes, uc timeout is counted against subtask's alignment time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this now, but I've added one last (trivial) suggestion.
Thanks a lot! I've included that last one suggestion and I'm going to merge it soon. |
This PR updates the docs to reflect changes implemented in https://issues.apache.org/jira/browse/FLINK-14712