-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22462][jdbc] Fix connection leak and stabilize JdbcExactlyOnceSinkE2eTest #15823
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a1fb269 (Thu Sep 23 17:26:33 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
df97ad0
to
323d87e
Compare
Let's sync up offline?
|
...nector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java
Outdated
Show resolved
Hide resolved
Thanks for reviewing the PR @curcur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much the fix and the extended test. A quick question: shouldn't we reorder the commits such that the fix appears before the test?
1. Add test against MySQL 2. Fix multiple issues in the test - Indefinite waiting in sources - Too early emission causing starvation in maps
I agree, reordered the commits and rebased them onto the latest master. |
XaFacadeImpl
(tolerate close errors for MySQL)