Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PoC add jobName and jobId tag in jobMananger process metric #15916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] PoC add jobName and jobId tag in jobMananger process metric #15916

wants to merge 1 commit into from

Conversation

qqibrow
Copy link
Contributor

@qqibrow qqibrow commented May 13, 2021

@flinkbot
Copy link
Collaborator

flinkbot commented May 13, 2021 •
edited

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3be4eb0 (Sat Aug 28 12:10:31 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 13, 2021 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

tillrohrmann
tillrohrmann requested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @qqibrow. I think that the solution does not generalize well because it relies on the fact that there is a file based JobGraph present. Moreover, it moves per-job-cluster specific behavior into the general ClusterEntrypoint which violates the separation of concerns.

flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
Comment on lines +327 to +338
FileJobGraphRetriever fileJobGraphRetriever =
FileJobGraphRetriever.createFrom(configuration, null);

String jobName = null;
String jobId = null;
try {
JobGraph jobGraph = fileJobGraphRetriever.retrieveJobGraph(configuration);
jobName = jobGraph.getName();
jobId = jobGraph.getJobID().toHexString();
} catch (FlinkException e) {
LOG.info("Not able to fetch JobGraph");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this only works for the Yarn per job cluster entrypoint and is not a general solution. For example, the application mode won't be supported. Hence, I think we cannot do it like this.

@qqibrow
Copy link
Contributor Author

qqibrow commented May 19, 2021

@tillrohrmann Thanks for reviewing! If so, do you have any recommendation where I can add this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann requested changes

Assignees
No one assigned
Labels
review=description?
Projects
None yet
Milestone
No milestone
4 participants
@qqibrow @flinkbot @tillrohrmann @rmetzger