Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22645][sql-parser] "ALTER VIEW" DDL for Flink dialect #15946

Closed
wants to merge 1 commit into from

Conversation

Airblader
Copy link
Contributor

@Airblader Airblader commented May 18, 2021

What is the purpose of the change

This introduces the ALTER VIEW DDL statements

ALTER VIEW … RENAME TO …
ALTER VIEW … AS …

to the (regular) Flink dialect. Previously, they were only part of the Hive dialect. The syntax follows that of the Hive dialect and is also in line with the syntax for tables.

Brief change log

  • Added DDL to the SQL parser using existing infrastructure from the Hive dialect

Verifying this change

This is mostly covered through existing tests, but Flink dialect test cases for the new syntax, specifically, have been added.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented May 18, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 69e9cf3 (Thu Sep 23 17:23:01 UTC 2021)

Warnings:

  • Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 18, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Airblader. LGTM but for just to clarify: Do we have actual end-to-end catalog tests somewhere?

This introduces the DDL

ALTER VIEW … RENAME TO …
ALTER VIEW … AS …

for the Flink dialect. These already exist for the Hive dialect, but
should be supported in the Flink dialect as well.

This change omits "ALTER VIEW … SET TBLPROPERTIES …" as this doesn't
(yet) make sense for the Flink dialect.
@Airblader
Copy link
Contributor Author

@twalthr I've added a couple of IT test cases for it as well now.

@twalthr twalthr closed this in 2343edb Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants