Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22721][ha] Add default implementation for HighAvailabilityServices.cleanupJobData #15969

Merged
merged 1 commit into from May 20, 2021

Conversation

tillrohrmann
Copy link
Contributor

In order to not break the HighAvailabilityServices interface, this commit adds a default
implementation for the HighAavilabilityServices.cleanupJobData method which does nothing.
Users of this interface are recommended to override this method and add a specific
implementation in order to clean up job specific HA services after a job completion.

@flinkbot
Copy link
Collaborator

flinkbot commented May 20, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7753542 (Sat Aug 28 12:11:01 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 20, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @XComp. Merging this PR now.

…ices.cleanupJobData

In order to not break the HighAvailabilityServices interface, this commit adds a default
implementation for the HighAavilabilityServices.cleanupJobData method which does nothing.
Users of this interface are recommended to override this method and add a specific
implementation in order to clean up job specific HA services after a job completion.

This closes apache#15969.
@tillrohrmann tillrohrmann merged commit 7753542 into apache:master May 20, 2021
@tillrohrmann tillrohrmann deleted the FLINK-22721 branch May 20, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants