[FLINK-3367] Add PublicEvolving and Internal annotations to classes in API modules #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
force-pushed
the
addPublicEvolvingInternal
branch
from
5f4831d
to
74016f5
Compare
|
Some of the internal sinks sources, such as File* Socket are Internal while others are PublicEvolving. Is there a reason behind this? |
|
The motivation for this was to to make those Internal which can be added via the ExecutionEnvironment. Sources that offer configuration parameters which are not accessible via the ExecutionEnvironment are PublicEvolving. |
|
I see. Might seem inconsistent, though. 😄 So maybe we should make all of them PublicEvolving. |
fhueske
force-pushed
the
addPublicEvolvingInternal
branch
from
74016f5
to
f7e2da8
Compare
|
Except for two questions, the PR looks good to merge. |
fhueske
force-pushed
the
addPublicEvolvingInternal
branch
from
f7e2da8
to
41b4b1a
Compare
|
Updated and rebased the PR. |
…a and flink-scala
…eaming-java and flink-streaming-scala
fhueske
force-pushed
the
addPublicEvolvingInternal
branch
from
41b4b1a
to
f12c07a
Compare
|
Merging this |
subhankarb
pushed a commit
to subhankarb/flink
that referenced
this pull request
Mar 17, 2016
…eaming-java and flink-streaming-scala This closes apache#1606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the commit from #1599.
It adds annotations to all classes in the following modules:
flink-coreflink-javaflink-scalaflink-streaming-javaflink-streaming-scalaBy adding annotations to every class, annotation management becomes easier and we can enforce annotations for all new classes in our API modules.