[FLINK-22865][python] Optimize state serialize/deserialize in PyFlink #16069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 98e5b65 (Tue Dec 14 09:04:54 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dianfu
reviewed
Jun 25, 2021
| @@ -1136,7 +1136,7 @@ def get_execution_environment(self): | |||
| return self._keyed_stream.get_execution_environment() | |||
|
|
|||
| def get_input_type(self): | |||
| return self._keyed_stream.get_type() | |||
| return _from_java_type(self._keyed_stream._original_data_type_info.get_java_type_info()) | |||
There was a problem hiding this comment.
What's the purpose of this change?
| return BinaryCoder() | ||
| else: | ||
| return PrimitiveArrayCoder(from_type_info(element_type)) | ||
| elif isinstance(type_info, BasicArrayTypeInfo): |
There was a problem hiding this comment.
Should also consider ObjectArrayTypeInfo
dianfu
reviewed
Jul 14, 2021
| @@ -324,11 +323,12 @@ def open(self, runtime_context: RuntimeContext, internal_timer_service: Internal | |||
| # TODO: the type info is just a placeholder currently. | |||
| # it should be the real type serializer after supporting the user-defined state type | |||
| # serializer | |||
| merging_sets_state_descriptor = ListStateDescriptor( | |||
| "merging-window-set", Types.PICKLED_BYTE_ARRAY()) | |||
| # merging_sets_state_descriptor = ListStateDescriptor( | |||
| def decode_from_stream(self, in_stream, length=0): | ||
| return self._decode_one_value_from_stream(in_stream) | ||
|
|
||
| def _decode_one_value_from_stream(self, in_stream: InputStream): |
There was a problem hiding this comment.
It seems not necessary to introduce such a method
dianfu
approved these changes
Jul 14, 2021
srinipunuru
pushed a commit
to srinipunuru/flink
that referenced
this pull request
Jul 21, 2021
rkhachatryan
pushed a commit
to rkhachatryan/flink
that referenced
this pull request
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request optimize state serialize/deserialize in PyFlink
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation