Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-22376 backport #16079

Merged
merged 4 commits into from Jun 7, 2021
Merged

Conversation

akalash
Copy link
Contributor

@akalash akalash commented Jun 4, 2021

What is the purpose of the change

Backport of #15885
*PR organizes the order of recycling of buffer inside of RecoveredChannelStateHandler *

Brief change log

  • BufferBuilder is able to recycle itself if there is no consumer was created
  • InputChannelRecoveredStateHandler doesn't recycle buffer inside of recover
  • ResultSubpartitionRecoveredStateHandler create buffer consumer inside recover rather than receiving it as parameter

Verifying this change

This change added tests and can be verified as follows:

  • Added tests for BufferBuilder, InputChannelRecoveredStateHandler, ResultSubpartitionRecoveredStateHandler

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…egment in order to avoid extracting it from the bufferBuilder

(cherry picked from commit 3974687)
…rship of the input Buffer

(cherry picked from commit 2293362)
…el#onBuffer in javadoc

(cherry picked from commit bc8c739)
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 4, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 700f10a (Thu Sep 23 17:23:10 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 4, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@pnowojski
Copy link
Contributor

Test failure is unrelated: https://issues.apache.org/jira/browse/FLINK-20329

Merging.

@pnowojski pnowojski merged commit 6a2f806 into apache:release-1.13 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants