-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22528][docs] Document latency tracking metrics for state accesses #16177
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0b171c5 (Thu Sep 23 17:54:59 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@rkhachatryan , would you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Myasuka
I've made some suggestions, PTAL.
Maybe @infoverload you also wanna take a look at this documentation PR. |
@@ -561,6 +561,17 @@ val counts: DataStream[(String, Int)] = stream | |||
}) | |||
``` | |||
|
|||
### 跟踪 keyed state 的访问延迟 | |||
|
|||
Flink also allows to track the keyed state access latency for all state-backends. This feature is disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flink also allows to track the keyed state access latency for all state-backends. This feature is disabled by default. | |
Flink also allows tracking the keyed state access latency for all state backends. This feature is disabled by default. |
same for English version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be okay and this also existed in many places within Flink's docs.
@@ -1642,7 +1642,7 @@ logged by `SystemResourcesMetricsInitializer` during the startup. | |||
</tbody> | |||
</table> | |||
|
|||
## Latency tracking | |||
## End-to-End record travelling latency tracking | |||
|
|||
Flink allows to track the latency of records travelling through the system. This feature is disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flink allows to track the latency of records travelling through the system. This feature is disabled by default. | |
Flink allows tracking the latency of records travelling through the system. This feature is disabled by default. |
same for English version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be okay and this also existed in many places within Flink's docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR, I don't have any further concerns.
Thanks for @rkhachatryan 's review, merging... |
What is the purpose of the change
Add document of latency tracking metrics for state accesses.
Brief change log
Add document of latency tracking metrics for state accesses.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation