Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-23033][python] Add the missing ObjectArrayTypeInfo #16220

Merged
merged 7 commits into from Jun 23, 2021
Merged

[FLINK-23033][python] Add the missing ObjectArrayTypeInfo #16220

merged 7 commits into from Jun 23, 2021

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Jun 21, 2021

What is the purpose of the change

This pull request adds the missing ObjectArrayTypeInfo

Verifying this change

This change added tests and can be verified as follows:

  • Added tests in test_from_java_type

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 21, 2021 •
edited

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 463920e (Thu Sep 23 17:27:28 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 21, 2021 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

HuangXingBo
HuangXingBo reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianfu Thanks a lot for the fix. Good Work. I only left some mirror comments.

docs/content/docs/dev/python/datastream/data_types.md

| PyFlink Type | Usage | Corresponding Python Type |
| PyFlink Type | Python Type | Java Type |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the corresponding doc in zh?

flink-python/pyflink/datastream/utils.py Outdated
@@ -66,7 +66,8 @@ def pickled_bytes_to_python_converter(data, field_type):
elif field_type == Types.FLOAT():
return field_type.from_internal_type(ast.literal_eval(data))
elif isinstance(field_type, BasicArrayTypeInfo) or \
isinstance(field_type, PrimitiveArrayTypeInfo):
isinstance(field_type, PrimitiveArrayTypeInfo) or \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to isinstance(field_type, (BasicArrayTypeInfo, PrimitiveArrayTypeInfo, ObjectArrayTypeInfo))

flink-python/pyflink/fn_execution/coders.py Outdated
@@ -36,7 +36,7 @@
'SmallIntCoder', 'IntCoder', 'FloatCoder', 'DoubleCoder', 'BinaryCoder', 'CharCoder',
'DateCoder', 'TimeCoder', 'TimestampCoder', 'LocalZonedTimestampCoder',
'BasicArrayCoder', 'PrimitiveArrayCoder', 'MapCoder', 'DecimalCoder', 'BigDecimalCoder',
'TupleCoder', 'TimeWindowCoder', 'CountWindowCoder']
'TupleCoder', 'TimeWindowCoder', 'CountWindowCoder', 'ObjectArrayCoder']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ObjectArrayCoder

flink-python/pyflink/fn_execution/coders.py Outdated
@@ -303,14 +303,14 @@ def __hash__(self):

class BasicArrayCoder(CollectionCoder):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to GenericArrayCoder?

flink-python/pyflink/fn_execution/coders.py Outdated
@@ -625,6 +625,8 @@ def from_type_info_proto(type_info):
return PrimitiveArrayCoder(from_type_info_proto(type_info.collection_element_type))
elif field_type_name == type_info_name.BASIC_ARRAY:
return BasicArrayCoder(from_type_info_proto(type_info.collection_element_type))
elif field_type_name == type_info_name.OBJECT_ARRAY:
return ObjectArrayCoder(from_type_info_proto(type_info.collection_element_type))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GenericArrayCoder?

@dianfu
Copy link
Contributor Author

dianfu commented Jun 22, 2021

@HuangXingBo Thanks for the review. Updated!

HuangXingBo
HuangXingBo approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dianfu dianfu merged commit a07450d into apache:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuangXingBo HuangXingBo HuangXingBo approved these changes

Assignees
No one assigned
Labels
component=API/Python review=description?
Projects
None yet
Milestone
No milestone
4 participants
@dianfu @flinkbot @HuangXingBo @rmetzger