[FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout #16227

akalash · 2021-06-21T17:35:17Z

What is the purpose of the change

This PR adds new configuration aligned-checkpoint-timeout instead of alignment-timeout

Brief change log

-alignment-timeout was deprecated
-aligned-checkpoint-timeout was added. It represents time since the global start of the checkpoint after which AC switches to UC

Verifying this change

This change added tests and can be verified as follows:

Added tests in AlternatingCheckpointTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2021-06-21T17:38:54Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4fa243a (Thu Sep 23 17:53:02 UTC 2021)

Warnings:

Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2021-06-21T18:12:02Z

CI report:

4fa243a Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

dawidwys

Overall looks good. Had one comment to the code. Could you also update the UC documentation page? https://ci.apache.org/projects/flink/flink-docs-master/docs/ops/state/unaligned_checkpoints/ I think adding a sentence or two about what does the timeout mean would be a nice touch.

...treaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java

...est/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingCheckpointsTest.java

dawidwys · 2021-06-28T11:47:00Z

...rc/main/java/org/apache/flink/runtime/jobgraph/tasks/CheckpointCoordinatorConfiguration.java

@@ -207,6 +208,7 @@ public int hashCode() {
                checkpointRetentionPolicy,
                isExactlyOnce,
                isUnalignedCheckpointsEnabled,
+                alignedCheckpointTimeout,


Good catch!

dawidwys · 2021-06-28T11:48:06Z

docs/layouts/shortcodes/generated/rest_v1_dispatcher.html

@@ -101,10 +101,10 @@
      "type" : "object",
      "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:DashboardConfiguration:Features",
      "properties" : {
-        "web-submit" : {


Out of curiosity. Do you know where does the reordering comes from? Is the file autogenerated? If you don't know don't bother looking for an answer.

This file is autogenerated but it looks like it is generated in alphabet order so it should be correct now. I can only guess but perhaps, initially, the author made these changes manually

… to UC is based on the global checkpoint start time rather than the local first barrier received time

…n aligned-checkpoint-timeout instead of alignment-timeout

akalash · 2021-06-28T13:34:05Z

@dawidwys, I added the documentation - https://github.com/apache/flink/pull/16227/files#diff-330cebde422d7911fd9cb5f32e58770389b13862cb372e6fdb276ba44bb3c4ac, I don't really sure what should I do with the old alignment timeout but as you can see I just deprecated it. I hope it is ok

dawidwys · 2021-06-28T13:40:39Z

Let's just drop the old value. It wasn't properly advertised and I think it doesn't make much sense to document it on that general page.

…timeout in WebUI

dawidwys

LGTM

rmetzger added review=description? component=<none> labels Jun 21, 2021

akalash force-pushed the flink-23041 branch 4 times, most recently from 757fe73 to 9a20519 Compare June 23, 2021 14:53

dawidwys reviewed Jun 28, 2021

View reviewed changes

akalash added 2 commits June 28, 2021 15:10

[FLINK-23041][streaming] Calculation of timeout for switching from AC…

e3c9cdd

… to UC is based on the global checkpoint start time rather than the local first barrier received time

[FLINK-23041][runtime] Added new well defined checkpoint configuratio…

13cc02a

…n aligned-checkpoint-timeout instead of alignment-timeout

akalash force-pushed the flink-23041 branch 2 times, most recently from 0f55f18 to 8613d50 Compare June 28, 2021 13:32

[FLINK-23041][webui] Renamed alignment_timeout to aligned_checkpoint_…

4fa243a

…timeout in WebUI

akalash force-pushed the flink-23041 branch from 8613d50 to 4fa243a Compare June 28, 2021 14:21

dawidwys approved these changes Jun 29, 2021

View reviewed changes

dawidwys closed this in 9d449ff Jun 29, 2021

flinkbot added component=Runtime/Checkpointing and removed component=<none> labels Mar 17, 2022

1996fanrui mentioned this pull request Nov 12, 2022

[FLINK-30002][checkpoint] Change the alignmentTimeout to alignedCheckpointTimeout #21303

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout #16227

[FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout #16227

akalash commented Jun 21, 2021

flinkbot commented Jun 21, 2021 •

edited

Loading

flinkbot commented Jun 21, 2021 •

edited

Loading

dawidwys left a comment

dawidwys Jun 28, 2021

dawidwys Jun 28, 2021

akalash Jun 28, 2021

akalash commented Jun 28, 2021

dawidwys commented Jun 28, 2021

dawidwys left a comment

[FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout #16227

[FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout #16227

Conversation

akalash commented Jun 21, 2021

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Jun 21, 2021 • edited Loading

Automated Checks

Review Progress

flinkbot commented Jun 21, 2021 • edited Loading

CI report:

dawidwys left a comment

Choose a reason for hiding this comment

dawidwys Jun 28, 2021

Choose a reason for hiding this comment

dawidwys Jun 28, 2021

Choose a reason for hiding this comment

akalash Jun 28, 2021

Choose a reason for hiding this comment

akalash commented Jun 28, 2021

dawidwys commented Jun 28, 2021

dawidwys left a comment

Choose a reason for hiding this comment

flinkbot commented Jun 21, 2021 •

edited

Loading

flinkbot commented Jun 21, 2021 •

edited

Loading