Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23243][docs-zh]Translate "SELECT & WHERE clause" page into Chinese #16418

Merged
merged 11 commits into from Jul 12, 2021
Merged

[FLINK-23243][docs-zh]Translate "SELECT & WHERE clause" page into Chinese #16418

merged 11 commits into from Jul 12, 2021

Conversation

edmondsky
Copy link
Contributor

What is the purpose of the change

Translate "SELECT & WHERE clause" page into Chinese

The page url is https://ci.apache.org/projects/flink/flink-docs-release-1.13/zh/docs/dev/table/sql/queries/select/

The markdown file is located in docs/content.zh/docs/dev/table/sql/select.md

Brief change log

  • Translate 'flink/docs/content.zh/docs/dev/table/sql/select.md'.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit af37ef9 (Thu Sep 23 18:01:15 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@edmondsky
Copy link
Contributor Author

@95chenjz
Ready to review

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@95chenjz 95chenjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution. I found a small mistake. I think it's ready to merge when it's fixed. you can cc Jark for merge.

docs/content.zh/docs/dev/table/sql/queries/select.md Outdated Show resolved Hide resolved
@edmondsky
Copy link
Contributor Author

cc @wuchong @xccui @klion26 @PatrickRen @becketqin . Could you review my PR when you're free? No hurry, looking for your feedback.

@wuchong
Copy link
Member

wuchong commented Jul 8, 2021

cc @RocMarshal , would you like to review this translation?

@RocMarshal
Copy link
Contributor

cc @RocMarshal , would you like to review this translation?

Hi, @wuchong , @edmondsky I'll review it ASAP. Thank you.

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edmondsky Thanks for your contribution. I made a few comments. Please take a look.

docs/content.zh/docs/dev/table/sql/queries/select.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/sql/queries/select.md Outdated Show resolved Hide resolved
edmondsky and others added 2 commits July 11, 2021 00:13
@edmondsky
[FLINK-23243]Translate "SELECT & WHERE clause" page into Chinese

Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
@edmondsky
[FLINK-23243]Translate "SELECT & WHERE clause" page into Chinese

Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
@edmondsky
Copy link
Contributor Author

@edmondsky Thanks for your contribution. I made a few comments. Please take a look.

Tthanks for your comments. I think it's all set. Please review that again. @RocMarshal

edmondsky and others added 2 commits July 11, 2021 21:58
[FLINK-23243]Translate "SELECT & WHERE clause" page into Chinese

Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
[FLINK-23243]Translate "SELECT & WHERE clause" page into Chinese

Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
@edmondsky
Copy link
Contributor Author

Thanks again :) @RocMarshal


```sql
SELECT select_list FROM table_expression [ WHERE boolean_expression ]
```

The `table_expression` refers to any source of data. It could be an existing table, view, or `VALUES` clause, the joined results of multiple existing tables, or a subquery. Assuming that the table is available in the catalog, the following would read all rows from `Orders`.
这里的 `table_expression` 可以是任意的数据来源。它可以是一张已经存在的表、视图或者 `VALUES` 子句,也可以是多个现有表的关联结果、或一个子查询。这里我们假设 `Orders` 表在 `Catalog` 中处于可用状态,那么下面的语句会从 `Orders` 表中读出所有的行。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数据来源->数据源

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's all set. @RocMarshal

@edmondsky
Copy link
Contributor Author

All of the style of "Catalog" have been changed to "Catalog" style. Is that okay? @RocMarshal

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @edmondsky very much for your effort and patience. Thanks for @95chenjz review.
LGTM +1. Now ping @wuchong

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 5a40a9b into apache:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants