Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23308] Optimize checks if SourceContext is closed #16429

Merged
merged 1 commit into from Jul 8, 2021

Conversation

dawidwys
Copy link
Contributor

@dawidwys dawidwys commented Jul 8, 2021

  • Remove unnecessary calls to checkNotClosed
  • Make the checkNotClosed private to enable inlining

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 00aeb24 (Thu Sep 23 17:59:56 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one question, and commit message/PR description should explain more what is this about (trying to optimise potential regression and you are not sure whether this is fixing something, but you want to try it out over a couple of days on the continuous benchmarking machines).

This commit tries to optimize checks on the hot path for closed
SourceContext. It removes unnecessary duplicated calls of
checkNotClosed.

There is no certainty it fixes the problem, however we want to run
benchmarks for a couple of days and see how it affects the performance.
@dawidwys
Copy link
Contributor Author

dawidwys commented Jul 8, 2021

@flinkbot run azure

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dawidwys dawidwys merged commit baa77dd into apache:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants