Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23314][cep] State left behind for short lived keys #16431

Closed
wants to merge 1 commit into from

Conversation

dawidwys
Copy link
Contributor

@dawidwys dawidwys commented Jul 8, 2021

What is the purpose of the change

Properly clean up state in CepOperator

Brief change log

Couple of improvements for state cleaning in the CepOperator.

  • register timer in order to advance time, if we keep count of records
    for certain timestamps
  • clear the namespace if there are no more timestamps we keep count of
    events for
  • clear up NfaState if there is only starting partial match

Verifying this change

This is a Work in Progress, needs a test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Couple of improvements for state cleaning in the CepOperator.
* register timer in order to advance time, if we keep count of records
for certain timestamps
* clear the namespace if there are no more timestamps we keep count of
events for
* clear up NfaState if there is only starting partial match
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5b0d1da (Thu Jul 08 12:15:03 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

|| !partialMatches.isEmpty()
// register timer if there are counters kept, so that we can clear them up
// if time advances without new events
|| partialMatches.getEventCounters().hasNext()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, is there any possibility of not registering the timer here?
I may have found a performance problem caused by registering the timer, which may have something to do with the code in this place. Can you take a look at this issue if possible? https://issues.apache.org/jira/browse/FLINK-23890

@dawidwys dawidwys closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants