Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23318][tests] Fix AkkaRpcActorTest.testOnStopFutureCompletionDirectlyTerminatesAkkaRpcActor #16438

Merged
merged 1 commit into from Jul 12, 2021

Conversation

tillrohrmann
Copy link
Contributor

After FLINK-23202 the AkkaRcpActorTest.testOnStopFutureCompletionDirectlyTerminatesAkkaRpcActor became unstable
because it assumed that RPC call after the RpcEndpoint is terminated won't be executed. With FLINK-23202 these
calls are now sent to the dead letter box which will result in a Failure response. Consequently, the second rpc
is now failing with an RecipientUnreachableException. This commit updates the test to assert for this condition.

Before, the test was passing because of a potential race condition where the second result future was not completed.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 9, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 48b3d8f (Fri Jul 09 09:06:24 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 9, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fix looks good to me!

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @rmetzger. Merging this PR now.

…irectlyTerminatesAkkaRpcActor

After FLINK-23202 the AkkaRcpActorTest.testOnStopFutureCompletionDirectlyTerminatesAkkaRpcActor became unstable
because it assumed that RPC call after the RpcEndpoint is terminated won't be executed. With FLINK-23202 these
calls are now sent to the dead letter box which will result in a Failure response. Consequently, the second rpc
is now failing with an RecipientUnreachableException. This commit updates the test to assert for this condition.

Before, the test was passing because of a potential race condition where the second result future was not completed.

This closes apache#16438.
@tillrohrmann tillrohrmann merged commit 72150ab into apache:master Jul 12, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23318 branch July 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants