Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23069][table-api-java] Support schemaless #executeInsert(TableDescriptor) #16470

Closed
wants to merge 3 commits into from

Conversation

Airblader
Copy link
Contributor

What is the purpose of the change

For Table#executeInsert, the schema can actually be inferred and thus is not required to be defined in the table descriptor, which simplifies the API usage in this case. However, we apply the same "merging" strategy between resolved and declared schema as we do during Table API <-> DataStream conversion.

Brief change log

  • Make the schema in TableDescriptor optional.
  • Merge resolved and declared schema for #executeInsert and build a new descriptor.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

  • TableSinkITCase (adjusted to use this new functionality)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit aa234d9 (Thu Sep 23 18:03:12 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@Airblader Airblader marked this pull request as ready for review July 13, 2021 05:56
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Airblader. This will be a quite useful feature. We should add more tests however.

@Airblader Airblader force-pushed the FLINK-23069 branch 2 times, most recently from 6623074 to 533cbed Compare July 14, 2021 05:33
@Airblader Airblader requested a review from twalthr July 14, 2021 05:34
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had some minor comments that I will fix while merging.

@Airblader Airblader force-pushed the FLINK-23069 branch 2 times, most recently from a772300 to bb6e928 Compare July 14, 2021 08:09
@Airblader
Copy link
Contributor Author

As discussed offline, I also added schema-less StatementSet#addInsert and also fixed the JavaDocs which was still mentioning the case of merging the physical schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants