Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23406][tests] Harden ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException #16514

Merged
merged 1 commit into from Jul 19, 2021

Conversation

tillrohrmann
Copy link
Contributor

This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 16, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c034b7e (Thu Sep 23 18:04:22 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 16, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zentol zentol self-assigned this Jul 19, 2021
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR now.

…tExitDueToUncaughtException

This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.

This closes apache#16514.
@tillrohrmann tillrohrmann merged commit c034b7e into apache:master Jul 19, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23406 branch July 19, 2021 12:00
srinipunuru pushed a commit to srinipunuru/flink that referenced this pull request Jul 21, 2021
…tExitDueToUncaughtException

This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.

This closes apache#16514.
rkhachatryan pushed a commit to rkhachatryan/flink that referenced this pull request Jul 22, 2021
…tExitDueToUncaughtException

This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.

This closes apache#16514.
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
…tExitDueToUncaughtException

This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.

This closes apache#16514.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants