New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23406][tests] Harden ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException #16514
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c034b7e (Thu Sep 23 18:04:22 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for the review @zentol. Merging this PR now. |
…tExitDueToUncaughtException This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock. This closes apache#16514.
2718fa8
to
c034b7e
Compare
…tExitDueToUncaughtException This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock. This closes apache#16514.
…tExitDueToUncaughtException This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock. This closes apache#16514.
…tExitDueToUncaughtException This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock. This closes apache#16514.
This commit hardens the ClusterUncaughtExceptionHandlerITCase.testExitDueToUncaughtException by not blocking
the ClusterEntrypoint's main thread and therefore releasing the ClusterEntrypoint.lock.