Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23419][streaming] Fixed the condition in testNextFirstCheckpointBarrierOvertakesCancellationBarrier in order to make the test more stable #16534

Merged
merged 1 commit into from Jul 21, 2021

Conversation

akalash
Copy link
Contributor

@akalash akalash commented Jul 19, 2021

…ntBarrierOvertakesCancellationBarrier in order to make the test more stable

What is the purpose of the change

PR fixes the test

Brief change log

Test condition was changed

Verifying this change

It test itself

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 19, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 363f244 (Thu Sep 23 18:07:40 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@curcur
Copy link
Contributor

curcur commented Jul 20, 2021

Hey @akalash thanks for creating the PR

  1. The azure failure does not seem to be related, could you please double-check to make sure it is not related
  2. I know it is very unlikely, do you think it is safer to use "greaterThanOrEqualTo" and "lessThanOrEqualTo". But I am fine to keep it as it is.

…ntBarrierOvertakesCancellationBarrier in order to make the test more stable
@curcur
Copy link
Contributor

curcur commented Jul 21, 2021

Failure does not seem to be relevant to this fix.

@curcur curcur merged commit 600ce81 into apache:release-1.12 Jul 21, 2021
@curcur
Copy link
Contributor

curcur commented Jul 21, 2021

Hmm,
[FLINK-23419][streaming] the title of the commit might need change, but anyway ==>
[FLINK-23419][runtime-checkpointing]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants