Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23489][docs] Change flink-config.yaml to flink-conf.yaml #16586

Merged
merged 2 commits into from Jul 26, 2021

Conversation

hapihu
Copy link
Contributor

@hapihu hapihu commented Jul 24, 2021

The relevant pages are as follows:

https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/cli/

https://ci.apache.org/projects/flink/flink-docs-master/zh/docs/deployment/cli/

The related documents are as follows:

docs/content/docs/deployment/cli.md

docs/content.zh/docs/deployment/cli.md

In these pages, conf/flink-config.yaml should be changed to conf/flink-conf.yaml

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 24, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2bc9d3d (Sat Aug 28 12:21:41 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 24, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the English doc docs/content/docs/deployment/cli.md as well?

@hapihu
Copy link
Contributor Author

hapihu commented Jul 26, 2021

Could you also update the English doc docs/content/docs/deployment/cli.md as well?

@wuchong , Hi,I also update the English doc docs/content/docs/deployment/cli.md in this pr.
Would you like to review it for me again? [抱拳][呲牙]

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 6df9bdf into apache:master Jul 26, 2021
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants