Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23495] [Connectors / Google Cloud PubSub] Make checkpoint optional for preview/staging mode #16596

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brachi-wernick
Copy link

@brachi-wernick brachi-wernick commented Jul 26, 2021

What is the purpose of the change

This PR add a new option for PubSub source called :withoutCheckpoint, to disable checkpoint verification.
This is useful for testing, and especially when using Ververica platform-> Sql editor (they disable checkpointing for preview cluster)

Brief change log

(for example:)

  • new option is added to PubSubSource called :checkpointDisabled, to disable checkpoint verification.
  • default value is false, meaning current behaviour will remain until explicit change to true.
  • If value set to true, the method hasNoCheckpointingEnabled will not raise error anymore.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no

  • The public API, i.e., is any changed class annotated with @Public(Evolving): no

  • The serializers: (yes / no / don't know) don't know

  • The runtime per-record code paths (performance sensitive): don't know

  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes (checkpointing)

  • The S3 file system connector: no

  • Does this pull request introduce a new feature? yes, kind of,

  • If yes, how is the feature documented? not documented (can you help me where should I document it)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit aecf658 (Mon Jul 26 11:17:08 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 26, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@brachi-wernick
Copy link
Author

Any chance I can get review on this? we talked on this direction in ticket FLINK-23495.
I would want also to add this to #16598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants