Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23531][table]Allow skip all change log for row-time deduplicate mini-batch #16630

Merged
merged 4 commits into from Aug 4, 2021

Conversation

Tartarus0zm
Copy link
Contributor

What is the purpose of the change

current we keep all change log for row-time deduplicate mini-batch,
we need buffer all record on heap.
In some cases, users do not need all change logs;
In this way, the memory pressure and the calculation pressure of downstream operators can be reduced.

Brief change log

add new impl RowTimeMiniBatchLatestChangelogDeduplicateFunction;

Verifying this change

Added test that validates that row-time deduplicate mini-batch disable send all change logs, the result is as expected.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@Tartarus0zm
Copy link
Contributor Author

@wuchong please take a look, if you have time. thanks

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2d838f1 (Thu Sep 23 18:53:40 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@JingsongLi JingsongLi self-requested a review August 2, 2021 07:22
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tartarus0zm for the contribution, left some comments.

@Tartarus0zm
Copy link
Contributor Author

@JingsongLi I have solved the problem you mentioned, please take a look.
thanks~

@Tartarus0zm
Copy link
Contributor Author

@JingsongLi thanks for your review. I fixed it

@Tartarus0zm Tartarus0zm force-pushed the FLINK-23531 branch 2 times, most recently from dee9c42 to 5b6bb39 Compare August 3, 2021 09:32
@Tartarus0zm
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! +1

@JingsongLi JingsongLi merged commit 4d8157f into apache:master Aug 4, 2021
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants