New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23531][table]Allow skip all change log for row-time deduplicate mini-batch #16630
Conversation
@wuchong please take a look, if you have time. thanks |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2d838f1 (Thu Sep 23 18:53:40 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tartarus0zm for the contribution, left some comments.
...c/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecDeduplicate.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecDeduplicate.java
Outdated
Show resolved
Hide resolved
.../table/runtime/operators/deduplicate/RowTimeMiniBatchLatestChangelogDeduplicateFunction.java
Outdated
Show resolved
Hide resolved
.../table/runtime/operators/deduplicate/RowTimeMiniBatchLatestChangelogDeduplicateFunction.java
Outdated
Show resolved
Hide resolved
.../table/runtime/operators/deduplicate/RowTimeMiniBatchLatestChangelogDeduplicateFunction.java
Outdated
Show resolved
Hide resolved
@JingsongLi I have solved the problem you mentioned, please take a look. |
...c/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecDeduplicate.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecDeduplicate.java
Outdated
Show resolved
Hide resolved
@JingsongLi thanks for your review. I fixed it |
dee9c42
to
5b6bb39
Compare
@flinkbot run azure |
5b6bb39
to
2d838f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! +1
… mini-batch This closes apache#16630
What is the purpose of the change
current we keep all change log for row-time deduplicate mini-batch,
we need buffer all record on heap.
In some cases, users do not need all change logs;
In this way, the memory pressure and the calculation pressure of downstream operators can be reduced.
Brief change log
add new impl
RowTimeMiniBatchLatestChangelogDeduplicateFunction
;Verifying this change
Added test that validates that row-time deduplicate mini-batch disable send all change logs, the result is as expected.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation