New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23616][python] Support to chain the Python DataStream operators as much as possible #16777
Conversation
… reduce the number of itcases
…s as much as possible
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit fa5fc95 (Wed Aug 11 07:35:54 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Thanks a lot for the PR. LGTM. Only left a minor comment.
@@ -736,8 +736,10 @@ def execute(self, job_name: str = None) -> JobExecutionResult: | |||
:return: The result of the job execution, containing elapsed time and accumulators. | |||
""" | |||
|
|||
gateway = get_gateway() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about moving these logic into the method _generate_stream_graph
cpdef process_outputs(self, WindowedValue windowed_value, results) | ||
|
||
cdef class NetworkOutputProcessor(OutputProcessor): | ||
cdef Operation _consumer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the attribute Operation _consumer
to the parent class OutputProcessor
?
@@ -19,15 +19,85 @@ | |||
# cython: infer_types = True | |||
# cython: profile=True | |||
# cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True | |||
from apache_beam.runners.worker.bundle_processor import DataOutputOperation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this import
statement to the back of these cimport
statement
…s as much as possible This closes apache#16777.
What is the purpose of the change
This pull request supports to chain the Python DataStream operators as much as possible.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation