Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23458][docs] Added the network buffer documentation along wit… #16988

Merged
merged 1 commit into from Sep 13, 2021

Conversation

akalash
Copy link
Contributor

@akalash akalash commented Aug 25, 2021

…h the buffer debloat doc

What is the purpose of the change

The documentation for network buffer along with buffer debloat

Brief change log

  • Added the documentation of the network buffer

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@akalash akalash marked this pull request as draft August 25, 2021 16:42
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e3a0f5f (Wed Aug 25 16:55:38 UTC 2021)

Warnings:

  • Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 25, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a section about manually configuring the amount of in-flight buffers? That for max throughput we recommend the default settings of exclusive buffers and floating buffers. For manually minimising the amount of the in-flight data the exclusive buffers can be set to 0 and the memory segment size can be decreased.

Additionally I think we don't have any warning/info message logged if not all configured amount of buffers was acquired. I think we should add this on the warning level. Especially after FLINK-16641, if we fail to allocate even a single exclusive buffer on the input gates, the performance would suffer dramatically and I think at the moment users would have no way of knowing that this has happened.

docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/ops/state/network_buffer.md Outdated Show resolved Hide resolved
@pnowojski
Copy link
Contributor

Also as we discussed off line, I think the best place for this docs is a sibling of this page: https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/memory/mem_tuning/

And can you add cross references from the configuration and memory configuration docs to this networ memory tuning page?

@akalash akalash marked this pull request as ready for review August 31, 2021 07:51
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/network_buffer.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment from my side. I would ask Daisy to take a look, as I'm pretty sure there are hundreds of linguistic errors that we can not catch (like missing the, an, a 🙄 )

docs/content/docs/deployment/memory/network_mem_tuning.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/config.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/memory/mem_setup.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/memory/mem_setup_tm.md Outdated Show resolved Hide resolved
docs/content/docs/deployment/memory/network_mem_tuning.md Outdated Show resolved Hide resolved
@akalash
Copy link
Contributor Author

akalash commented Sep 9, 2021

@infoverload, thanks for the suggestions. I have applied them all. If you have more comments I will wait for them if not, please, approve the PR if it looks good to you.

@akalash
Copy link
Contributor Author

akalash commented Sep 9, 2021

It looks like everybody has finished with the review of this PR so if there are no objections I will squash commits and then we can merge it. @pnowojski , @infoverload

@pnowojski
Copy link
Contributor

Yes, please squash the commits.

@pnowojski pnowojski merged commit 7901f26 into apache:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants