Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.13][FLINK-21853][e2e] Harden common_ha.sh#ha_tm_watchdog #17139

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

tillrohrmann
Copy link
Contributor

Backport of #17137 to release-1.13.

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 3, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 777d90a (Fri Sep 03 12:58:35 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 3, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

This commit hardens the common_ha.sh#ha_tm_watchdog function by always starting
the expected number of TaskManagers. This will ensure that the e2e tests that are
using this function also pass if a TaskManager dies accidentally.
…ter_datastream.sh and test_ha_datastream.sh

This commit reduces the number of JM kills in test_ha_per_job_cluster_datastream.sh and test_ha_datastream.sh because on
CI killing the JM 3 times can take more than the current timeout (15 minutes) (2 minutes per successful checkpoint, 8
successful checkpoints required to pass).

This closes apache#17139.
@tillrohrmann tillrohrmann merged commit 31df254 into apache:release-1.13 Oct 1, 2021
@tillrohrmann tillrohrmann deleted the FLINK-21853-113 branch October 1, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants