New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-3482] implement union translation #1715
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import org.apache.calcite.rel.core.Join | ||
import org.apache.calcite.rel.core.Union | ||
|
||
class FlinkJoinUnionTransposeRule( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a notice that this file was copied from Apache Calcite and briefly describe what you changed and why?
Looks good. Can be merged after the comment was added. Thanks! |
+1 to merge |
Thanks, I will merge. |
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2016
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion This closes #1715
vasia
added a commit
to vasia/flink
that referenced
this pull request
Mar 16, 2016
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion This closes apache#1715
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2016
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion This closes #1715
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion This closes apache#1715
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
- implement custom JoinUnionTransposeRules because Calcite's only match with LogicalUnion This closes apache#1715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds union support to Table on Calcite. I've implemented a custom
JoinUnionTransposeRule
because Calcite's only matches with LogicalUnion.