Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3482] implement union translation #1715

Closed
wants to merge 1 commit into from

Conversation

vasia
Copy link
Contributor

@vasia vasia commented Feb 25, 2016

This PR adds union support to Table on Calcite. I've implemented a custom JoinUnionTransposeRule
because Calcite's only matches with LogicalUnion.

import org.apache.calcite.rel.core.Join
import org.apache.calcite.rel.core.Union

class FlinkJoinUnionTransposeRule(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a notice that this file was copied from Apache Calcite and briefly describe what you changed and why?

@fhueske
Copy link
Contributor

fhueske commented Feb 26, 2016

Looks good. Can be merged after the comment was added. Thanks!

@fhueske
Copy link
Contributor

fhueske commented Feb 26, 2016

+1 to merge

@vasia
Copy link
Contributor Author

vasia commented Feb 26, 2016

Thanks, I will merge.

- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion
asfgit pushed a commit that referenced this pull request Feb 26, 2016
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion

This closes #1715
@vasia vasia closed this Feb 26, 2016
@vasia vasia deleted the union branch March 7, 2016 09:34
vasia added a commit to vasia/flink that referenced this pull request Mar 16, 2016
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion

This closes apache#1715
asfgit pushed a commit that referenced this pull request Mar 18, 2016
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion

This closes #1715
fijolekProjects pushed a commit to fijolekProjects/flink that referenced this pull request May 1, 2016
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion

This closes apache#1715
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion

This closes apache#1715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants