Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24117][HA]Remove unHandledErrorListener in ZooKeeperLeaderElec… #17150

Closed
wants to merge 1 commit into from

Conversation

Aitozi
Copy link
Contributor

@Aitozi Aitozi commented Sep 5, 2021

…tionDriver and ZooKeeperLeaderRetrievalDriver

What is the purpose of the change

Remove the unnecessary curator handlers.

Verifying this change

This change is a code cleanup without any test coverage.

@Aitozi
Copy link
Contributor Author

Aitozi commented Sep 5, 2021

cc @tillrohrmann

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 5, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 95cca61 (Sun Sep 05 03:59:31 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 5, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @Aitozi. The changes look good to me. Merging this PR now.

…tionDriver and ZooKeeperLeaderRetrievalDriver

add tests

This closes apache#17150.
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Sep 30, 2021
…tionDriver and ZooKeeperLeaderRetrievalDriver

add tests

This closes apache#17150.
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…tionDriver and ZooKeeperLeaderRetrievalDriver

add tests

This closes apache#17150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants