[FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()

[twalthr]

What is the purpose of the change

Reduces friction by not throwing an exception for multi-rowtime queries for collect() and print().

Verifying this change

This change added tests and can be verified as follows: TableITCase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9dabc5a (Thu Sep 09 11:57:07 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[MartijnVisser]

Shouldn't we revert the documentation changes from #17183 when merging this?

[flinkbot]

CI report:

• 7390bb7 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[twalthr]

@MartijnVisser the documented query is still correct. I was planning to merge this only to master, so we could revert you change only there.

[matriv]

Wouldn't it be "cleaner" if an isCollectSink() method (or simplyisCollect()) is introduced to the iface?
Or alternatively, if the method is implemented in a utility class in that package, so that changing the class to public just for the purpose of instanceof call is avoided?

[Airblader]

Wouldn't it be "cleaner" if an isCollectSink() method (or simplyisCollect()) is introduced to the iface?

DynamicTableSink is a public API, so we'd be throwing a method into it for internal purposes. Such a method also breaks the abstraction, because you're asking the interface for whether it is a specific implementation.

Or alternatively, if the method is implemented in a utility class in that package, so that changing the class to public just for the purpose of instanceof call is avoided?

Then you'd just have to make that utility public instead, no?

[matriv]

DynamicTableSink is a public API, so we'd be throwing a method into it for internal purposes. Such a method also breaks the abstraction, because you're asking the interface for whether it is a specific implementation.

True, thx!

Then you'd just have to make that utility public instead, no?

Yep, not insisting, just to me seems a bit cleaner than exposing the class as public just to enable the instanceof call.

[MartijnVisser]

LGTM

[twalthr]

@flinkbot run azure

[twalthr]

@flinkbot run azure

[twalthr]

@flinkbot run azure