Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24219][doc]Translate "SET Statements" page of "SQL" into Chinese #17223

Merged
merged 2 commits into from Sep 14, 2021

Conversation

hapihu
Copy link
Contributor

@hapihu hapihu commented Sep 9, 2021

Translate "SET Statements" page of "SQL" into Chinese

https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/table/sql/set/

docs/content.zh/docs/dev/table/sql/set.md

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bd3cea2 (Thu Sep 09 15:58:37 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member

wuchong commented Sep 13, 2021

cc @RocMarshal , do you have time to help reviewing this?

@RocMarshal
Copy link
Contributor

@wuchong @hapihu OK. I'll check it ASAP.

## Syntax

```sql
SET ('key' = 'value')?
```

If no key and value are specified, it just prints all the properties. Otherwise, set the key with specified value.
如果没有指定 key value,它仅仅打印所有属性。否则,它会使用指定的 value 来设置 key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 否则,它会为 key 设置指定的 value 值。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,It sounds clearly and concisely.
I have updated it as suggested.

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hapihu for the update. LGTM+1.
Hi, @wuchong , please let us know what's your opinion. Thank you.

@wuchong wuchong merged commit 94c5077 into apache:master Sep 14, 2021
jianyun8023 pushed a commit to streamnative/flink that referenced this pull request Sep 22, 2021
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants