Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict #17319

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

xmarker
Copy link
Contributor

@xmarker xmarker commented Sep 18, 2021

What is the purpose of the change

Fix PulsarSourceITCase fails due to port conflict

Brief change log

  • PulsarMockRuntime use runtime dynamic port

Verifying this change

(Please pick either of the following options)

This change is to fix unit test failed issue .

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 25ccc21 (Sat Sep 18 08:55:00 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 18, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unused import, and if this change works then the PordBindingUtils can be removed.

@zentol zentol self-assigned this Sep 20, 2021
@syhily
Copy link
Contributor

syhily commented Sep 20, 2021

There's an unused import, and if this change works then the PordBindingUtils can be removed.

I have checked the internal logic on the Pulsar side. Change the port to zero should work for both Pulsar broker and Pulsar WebService. Tks for your fix.

@syhily
Copy link
Contributor

syhily commented Sep 20, 2021

@xmarker PortBindingUtils should also be removed.

@xmarker
Copy link
Contributor Author

xmarker commented Sep 21, 2021

@xmarker PortBindingUtils should also be removed.

Hi syhily , thinks for review,I checked again and PortBindingUtils import has been removed by the second commit

@syhily
Copy link
Contributor

syhily commented Sep 21, 2021

@xmarker PortBindingUtils should also be removed.

Hi syhily , thinks for review,I checked again and PortBindingUtils import has been removed by the second commit

I mean, remove the PortBindingUtils class.

@xmarker
Copy link
Contributor Author

xmarker commented Sep 21, 2021

@xmarker PortBindingUtils should also be removed.

Hi syhily , thinks for review,I checked again and PortBindingUtils import has been removed by the second commit

I mean, remove the PortBindingUtils class.

OK, I pushed again

@zentol zentol merged commit 389eb73 into apache:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants