-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-24329][connector/pulsar] Fix PulsarSourceITCase fails due to port conflict #17319
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 25ccc21 (Sat Sep 18 08:55:00 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an unused import, and if this change works then the PordBindingUtils can be removed.
...rc/test/java/org/apache/flink/connector/pulsar/testutils/runtime/mock/PulsarMockRuntime.java
Show resolved
Hide resolved
I have checked the internal logic on the Pulsar side. Change the port to zero should work for both Pulsar broker and Pulsar WebService. Tks for your fix. |
@xmarker |
Hi syhily , thinks for review,I checked again and PortBindingUtils import has been removed by the second commit |
I mean, remove the |
OK, I pushed again |
What is the purpose of the change
Fix PulsarSourceITCase fails due to port conflict
Brief change log
Verifying this change
(Please pick either of the following options)
This change is to fix unit test failed issue .
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation