Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24347][connectors/kafka] Keep idle source readers if paralleli… #17327

Closed
wants to merge 1 commit into from

Conversation

fapaul
Copy link

@fapaul fapaul commented Sep 21, 2021

…sm is higher than partitions in KafkaSource

What is the purpose of the change

Before this commit the enumerator signaled the leftover source readers
without a partition to finish. This caused that checkpointing was not
possible anymore because it is only supported if all tasks are running
or FLIP-147 is enabled.

Brief change log

  • Only send the signal to finish if the Source is executed in BOUNDED mode.

Verifying this change

  • Changed the existing test case for parallelism > partitions to assert that a checkpoint is taken

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9408d97 (Tue Sep 21 12:46:13 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 21, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@StephanEwen StephanEwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, +1 to merge this.

Minor comment inline.

…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers
without a partition to finish. This caused that checkpointing was not
possible anymore because it is only supported if all tasks are running
or FLIP-147 is enabled.
StephanEwen pushed a commit that referenced this pull request Sep 21, 2021
…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers without a partition to finish.
This caused that checkpointing was not possible anymore because it is only supported if all tasks are
running or FLIP-147 is enabled.

This closes #17327
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers without a partition to finish.
This caused that checkpointing was not possible anymore because it is only supported if all tasks are
running or FLIP-147 is enabled.

This closes apache#17327
jnh5y pushed a commit to jnh5y/flink that referenced this pull request Dec 18, 2023
…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers without a partition to finish.
This caused that checkpointing was not possible anymore because it is only supported if all tasks are
running or FLIP-147 is enabled.

This closes apache#17327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants