[FLINK-24459] Performance improvement of file sink #17416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0807e52 (Wed Oct 06 07:52:55 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
hililiwei
reviewed
Oct 9, 2021
Comment on lines
119
to
130
| if (needsEscaping(c)) { | ||
| sb.append('%'); | ||
| sb.append(String.format("%1$02X", (int) c)); | ||
| } else { | ||
| if (sb == null) { | ||
| sb = new StringBuilder(path.length() + 2); | ||
| for (int j = 0; j < i; j++) { | ||
| sb.append(path.charAt(j)); | ||
| } | ||
| } | ||
| escapeChar(c, sb); | ||
| } else if (sb != null) { | ||
| sb.append(c); | ||
| } | ||
| } |
There was a problem hiding this comment.
Will an incorrect result be returned if the character need to be escaped is in the middle?
There was a problem hiding this comment.
It works correctly. I added several units that cover the scenarios of head, middle, tail, missing, and combined control characters
hililiwei
approved these changes
Oct 11, 2021
niklassemmler
pushed a commit
to niklassemmler/flink
that referenced
this pull request
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request improves performance of file sink on Nexmark q10.
Brief change log
Integer.toHexStringinstead ofString.formatStringBuilderdepending on the original string length instead of the default valueVerifying this change
This change added tests and can be verified as follows:
PartitionPathUtilsTest.testEscapeCharverifying the original behavior ofString.formatis keptDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation