[FLINK-24488][connectors/kafka] KafkaRecordSerializationSchemaBuilder does not forward timestamp

[xmarker]

What is the purpose of the change

Fix KafkaRecordSerializationSchemaBuilder does not forward timestamp issue

Brief change log

• Correct KafkaRecordSerializationSchemaWrapper.serialize to use a with timestamp ProducerRecord construct
• Add a unit test

Verifying this change

This change added tests and can be verified as follows:

• Use KafkaRecordSerializationSchemaBuilderTest.testSerializeRecordWithTimestamp to test it

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not documented)

[flinkbot]

CI report:

• 24f0a46 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit def7ab0 (Wed Oct 13 15:35:46 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[fapaul]

@xmarker thanks for your contribution. Overall the changes look good but can you fix the formatting issues?

You can run mvn spotless:apply to reformat the code. Currently, your submission fails on the CI.

[xmarker]

@xmarker thanks for your contribution. Overall the changes look good but can you fix the formatting issues?

You can run mvn spotless:apply to reformat the code. Currently, your submission fails on the CI.

Think you for your reminder, I have run spotless and pushed again.

[fapaul]

@flinkbot run azure

[fapaul]

@xmarker can you rebase your changes on the latest master. Some tests seem to fail and I wonder if these instabilities are fixed on the latest master version.

[xmarker]

@xmarker can you rebase your changes on the latest master. Some tests seem to fail and I wonder if these instabilities are fixed on the latest master version.

[xmarker]

@fapaul I have pushed with rebase , thinks for your review

[fapaul]

@xmarker can you have a look at the failing tests. I checked out your branch at it seems the KafkaSinkITCase is crash looping. It seems something with the timestamp conversion does not properly work.

[xmarker]

@fapaul I have debug KafkaSinkITCase on my computer , I found the failure cause was due to SinkWriter.timestamp() is a negative number, when kafka producer serialize the record throws a runtime exception, and then flink task failover repeatedly, now i have fixed it and run KafkaSinkITCase no problem anymore.

[fapaul]

Thanks for the quick fix the changes look good. 👍
Can you finally squash all your commits together? It will make merging the PR easier.

[xmarker]

@fapaul OK,I squashed commits and pushed again.

[AHeise]

Thank you for your contribution! Could you please create a backport PR for 1.14?