-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17782] Add array,map,row types support for parquet row writer #17542
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9b11c30 (Fri Oct 22 01:29:38 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@JingsongLi could you help to review this PR ? |
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
@snuyanzin updated in latest commit |
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Show resolved
Hide resolved
LGTM |
@JingsongLi Would you like to take a look? |
d3fc889
to
0a653d3
Compare
rebase onto latest master branch to fix python tests error |
Sorry for the late response, I will take a review in the next few days, hope you are still active. |
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Show resolved
Hide resolved
...ink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetSchemaConverter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...ink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java
Outdated
Show resolved
Hide resolved
@meetjunsu Thanks for the contribution. Left some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update. @meetjunsu
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Outdated
Show resolved
Hide resolved
...s/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
Show resolved
Hide resolved
...ink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @meetjunsu for the update, looks good to me!
@meetjunsu Can you create PR for modifying this page: https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/formats/parquet/#data-type-mapping |
I create https://issues.apache.org/jira/browse/FLINK-25179 for documentation, comment it if you want to take it. |
@JingsongLi @meetjunsu https://issues.apache.org/jira/browse/FLINK-31197 was filed end of last year and notes that we can't write nested Array, Row, Map types, because the respective |
What is the purpose of the change
In order to support complex types, three new writers will be added to ParquetRowDataWriter, namely ArrayWriter, MapWriter, RowWriter.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation