Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17782] Add array,map,row types support for parquet row writer #17542

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

meetjunsu
Copy link
Contributor

What is the purpose of the change

In order to support complex types, three new writers will be added to ParquetRowDataWriter, namely ArrayWriter, MapWriter, RowWriter.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9b11c30 (Fri Oct 22 01:29:38 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@meetjunsu
Copy link
Contributor Author

@JingsongLi could you help to review this PR ?

@meetjunsu
Copy link
Contributor Author

@snuyanzin updated in latest commit

@snuyanzin
Copy link
Contributor

LGTM

@meetjunsu
Copy link
Contributor Author

@JingsongLi Would you like to take a look?

@meetjunsu
Copy link
Contributor Author

rebase onto latest master branch to fix python tests error

@JingsongLi
Copy link
Contributor

Sorry for the late response, I will take a review in the next few days, hope you are still active.

@JingsongLi JingsongLi self-requested a review December 1, 2021 03:47
@JingsongLi
Copy link
Contributor

@meetjunsu Thanks for the contribution. Left some comments.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update. @meetjunsu

@JingsongLi
Copy link
Contributor

@flinkbot run azure

@meetjunsu
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meetjunsu for the update, looks good to me!

@JingsongLi JingsongLi merged commit dac6425 into apache:master Dec 6, 2021
@JingsongLi
Copy link
Contributor

@JingsongLi
Copy link
Contributor

I create https://issues.apache.org/jira/browse/FLINK-25179 for documentation, comment it if you want to take it.

@uce
Copy link
Contributor

uce commented Feb 20, 2024

@JingsongLi @meetjunsu https://issues.apache.org/jira/browse/FLINK-31197 was filed end of last year and notes that we can't write nested Array, Row, Map types, because the respective write methods have not been implemented. I understand that the PR is a few years old by now, but do you remember if there was a reason to skip the implementation of those methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants