Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15987][table-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException #17547

Closed
wants to merge 2 commits into from

Conversation

xuyangzhong
Copy link
Contributor

What is the purpose of the change

This pull request mainly helps give users clearer exception messages when the divisor is zero. Before, 1.0e0 / 0.0e0 will be computed to infinity and when converting it to decimal, an exception "Infinite or NaN" is thrown . Now we follow the SQL Standard: throw "Division by zero".

Brief change log

  • add validate function in ExpressionReducer.
  • add a rule in ExpressionTestBase to fire the expression reducer.
  • change some existing test cases.
  • add some test cases to verify this change.

Verifying this change

  • Some test cases have been added to verify this change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

testSqlApi("truncate(42.345)", "42")
testSqlApi("truncate(cast(42.345 as decimal(5, 3)), 2)", "42.34")
testSqlApi("truncate(42.345)", "42.000")
testSqlApi("truncate(cast(42.345 as decimal(5, 3)), 2)", "42.340")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the rule PROJECT_REDUCE_EXPRESSIONS is added into ExpressionTestBase, the bug [FLINK-23614] happens. And the bug is only fixed in 1.15.

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 479f8df (Fri Oct 22 09:34:17 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants