Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-16206][table-planner] Support JSON_ARRAYAGG #17562

Closed
wants to merge 1 commit into from
Closed

[FLINK-16206][table-planner] Support JSON_ARRAYAGG #17562

wants to merge 1 commit into from

Conversation

Airblader
Copy link
Contributor

What is the purpose of the change

This introduces JSON_ARRAYAGG akin to JSON_OBJECTAGG from #17549.

Note that this PR is based off of that PR and thus needs to be rebased once #17549 is merged. Keeping it in draft until then.

supersedes #11370

Verifying this change

  • JsonAggregationFunctionsITCase
  • WrapJsonAggFunctionArgumentsRuleTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs + JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 25, 2021 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7a90ad8 (Mon Oct 25 18:40:01 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

twalthr
twalthr requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Airblader. I added some final comments.

...rc/main/java/org/apache/flink/table/planner/functions/aggfunctions/JsonArrayAggFunction.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/flink/table/planner/functions/aggfunctions/JsonArrayAggFunction.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/flink/table/planner/functions/aggfunctions/JsonArrayAggFunction.java
try {
for (final StringData item : acc.list.get()) {
final JsonNode itemNode =
getNodeFactory().rawValueNode(new RawValue(item.toString()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also somehow sort the list? otherwise the merge might behave non-deterministic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is actually a problem. In JSON_OBJECTAGG we sorted the keys, and that's fine, but arrays are order-sensitive. Maybe we shouldn't support merge at all? We'd need WITHIN GROUP here, but I'm guessing Calcite doesn't support that keyword there yet (will have to check, though).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed merge for now, documented the limitation and raised FLINK-24664. Since we're facing the same issue for FIRST_VALUE / LAST_VALUE (and in theory also e.g. LISTAGG), I've also cross-linked them.

twalthr
twalthr approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM

@Airblader @twalthr
[FLINK-16206][table] Support JSON_ARRAYAGG
3a3daa5 
We represent (NULL|ABSENT) ON NULL as two separate built-in functions
for now. This is necessary because otherwise we would have to ship
the symbol across the network for each record, which leads to various
problems. Calcite essentially uses the same workaround. This is the
same as was done for JSON_OBJECTAGG.

This closes apache#17562.
@twalthr
Copy link
Contributor

twalthr commented Oct 27, 2021

@flinkbot run azure

@twalthr twalthr marked this pull request as ready for review October 27, 2021 17:26
@Airblader
Copy link
Contributor Author

@flinkbot run azure

@twalthr twalthr closed this in fcdba99 Oct 28, 2021
@twalthr twalthr mentioned this pull request Oct 28, 2021
Closed
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
@Airblader @niklassemmler
[FLINK-16206][table] Support JSON_ARRAYAGG
b9e2c7a 
We represent (NULL|ABSENT) ON NULL as two separate built-in functions
for now. This is necessary because otherwise we would have to ship
the symbol across the network for each record, which leads to various
problems. Calcite essentially uses the same workaround. This is the
same as was done for JSON_OBJECTAGG.

This closes apache#17562.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalthr twalthr twalthr approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API
Projects
None yet
Milestone
No milestone
4 participants
@Airblader @flinkbot @twalthr @rmetzger