Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24676][table-planner] Fix schema mismatch exception if explain insert with partial column #17584

Closed
wants to merge 1 commit into from

Conversation

godfreyhe
Copy link
Contributor

What is the purpose of the change

Fix schema mismatch exception if explain insert with partial column, please refer to the desc of FLINK-24676 to see the example

Brief change log

  • PreValidateReWriter should consider SqlRichExplain if the statement is insert

Verifying this change

This change added tests and can be verified as follows:

  • Extended test in TableEnvironmentTest#testExecuteSqlWithExplainInsert to test the change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 28, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 0d91821 (Thu Oct 28 02:43:54 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@wenlong88
Copy link
Contributor

LGTM

@godfreyhe
Copy link
Contributor Author

Thanks for the review, I will merge it

@godfreyhe godfreyhe closed this in 37f8b38 Oct 28, 2021
@godfreyhe godfreyhe deleted the FLINK-24676 branch October 28, 2021 14:31
godfreyhe added a commit to godfreyhe/flink that referenced this pull request Oct 28, 2021
… insert with partial column

This closes apache#17584

(cherry picked from commit 37f8b38)
godfreyhe added a commit that referenced this pull request Oct 28, 2021
… insert with partial column

This closes #17584

(cherry picked from commit 37f8b38)
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants