-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-24742][table][docs] Add info about SQL client key strokes to docs #17649
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7081987 (Tue Nov 02 22:30:36 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
d85c89b
to
82848c8
Compare
Hi @MartijnVisser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It would be great if we can figure something out to also cover Mac keyboard users before merging this?
Added for Mac (tested on 2 relatively old Macs (before M1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the Linux short cuts. The MacOS short cuts look reasonable comparing it to the Linux once. I have two suggestions but generally, it looks fine.
@flinkbot run azure the failure is related to https://issues.apache.org/jira/browse/FLINK-24119 |
@flinkbot run azure |
@MartijnVisser Are we ok to merge that? |
Yeah I think it's fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I missed that in the first round but could you add the section to the Chinese version of the documentation as well? Copy&paste should be good enough. It looks like this is the right location for including the subsection.
@flinkbot run azure |
0e0fece
to
edac2db
Compare
Rebased since latest failure is related to removed elasticsearch module and the PR was done before it happened |
What is the purpose of the change
The PR adds info about key-strokes in SQL client to docs
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation