[FLINK-3611] [docs] corrected link in CONTRIBUTING.md #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @s1ck, thanks for opening pull request! I would like to change this link to "Contributing Code" (http://flink.apache.org/contribute-code.html) page rather than "Coding Guidelines". How about this? |
|
Sounds good, but then I would change the text to: |
|
+1 for your suggestion @s1ck. |
|
+1, Looks good to me. |
|
Merging |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Mar 22, 2016
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.