[FLINK-24971][tests] Adding retry mechanism in case git clone fails

[MartijnVisser]

What is the purpose of the change

• There are multiple occurrences of the Bash based Streaming File Sink s3 end-to-end test stalled on azure failing. After analysis, all failures have in common that git clone of flink-shaded is failing. This PR introduces a retry mechanism in case a git clone fails.

Brief change log

• Added retry mechanism to git clone of flink-shaded

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e26f936 (Tue Nov 23 09:03:15 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 8df3b66 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[MartijnVisser]

Ran the test locally:
FLINK_DIR=/Users/martijnvisser/Developer/flink/build-target /Users/martijnvisser/Developer/flink/flink-end-to-end-tests/run-single-test.sh skip "/Users/martijnvisser/Developer/flink/flink-end-to-end-tests/test-scripts/test_file_sink.sh s3 StreamingFileSink"

The logs show:

BUILDING flink-shaded-netty-tcnative-static
Executing command: git clone https://github.com/apache/flink-shaded.git
Cloning into 'flink-shaded'...

Result:

[PASS] '/Users/martijnvisser/Developer/flink/flink-end-to-end-tests/test-scripts/test_file_sink.sh s3 StreamingFileSink' passed after 3 minutes and 34 seconds! Test exited with exit code 0.

[AHeise]

LGTM!