[FLINK-24446][Table SQL/Planner] Casting from STRING to TIMESTAMP_LTZ looses fractional seconds

[shenzhu]

What is the purpose of the change

FLINK-24446: Casting from STRING to TIMESTAMP_LTZ looses fractional seconds.

Brief change log

• Update toTimestamp in DateTimeUtils.java to support strings with more than 23 characters.

Verifying this change

This change is already covered by existing tests, such as CastRulesTest.java.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[flinkbot]

CI report:

• c9abec7 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c0c5a63 (Thu Nov 25 01:53:25 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[snuyanzin]

May be a stupid question however could you please clarify why in String value there is 123456789 as fractions of seconds and in target 789000000 ?

[snuyanzin]

May be a stupid question however could you please clarify why in String value there is 123456789 as fractions of seconds and in target 789000000 ?

[matriv]

@snuyanzin Apologies for the delay on this one, we've taken over this, and this PR is superseded by:
#18632

[Airblader]

Closing this as it has been superseded. Thank you for submitting the PR!