New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25109][Table SQL/Client] Update jline3 to 3.21.0 #17961
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b12ff35 (Tue Nov 30 11:12:19 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@MartijnVisser sorry for the poke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snuyanzin It looks good to me. I'll fix the commit message (it doesn't include the touched component) and then I'll merge it :) Thanks a lot for the PR.
b12ff35
to
f8707bd
Compare
What is the purpose of the change
The PR updates jline3 to 3.21.0
It brings a number of features which could be used in FLIP-189
like rgb
support in style (could be used for prompts and highlighting)
line numbers support in prompt continuation
autopairing, display hints during completion
Verifying this change
This is just a version update, so only existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation