Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25189][connectors/elasticsearch] Update Elasticsearch sinks to latest minor versions #18038

Merged
merged 3 commits into from Dec 8, 2021

Conversation

alpreu
Copy link
Contributor

@alpreu alpreu commented Dec 7, 2021

What is the purpose of the change

We want to update the elasticsearch sink connectors to use the latest available minor version for Elasticsearch 6 and 7.

Brief change log

  • flink-connector-elasticsearch-base and flink-connector-elasticsearch-7 have been updated to Elasticsearch v7.15.2
  • flink-connector-elasticsearch-6 has been updated to Elasticsearch v6.8.20
  • Some classes (e.g. TimeValue) have been relocated by Elastic in between ES7 versions, therefore the ElasticsearchApiCallBridge for the old interface as well as the ElasticsearchXSinkBuilder for the new interfaces had to be changed to accommodate the different module locations of the class.
  • correct the connector docs to state that foe each major versions the connector is compatible across all minor versions

Verifying this change

This change is already covered by the existing tests, such as the modules unit tests and e2e tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 7, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 7, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 84c2b41 (Tue Dec 07 09:14:18 UTC 2021)

Warnings:

  • 5 pom.xml files were touched: Check for build and licensing issues.
  • Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link

@fapaul fapaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the cleanup. Looks good but I left some minor questions.

@fapaul fapaul merged commit d8d3779 into apache:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants