Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose #18089

Conversation

TanYuxin-tyx
Copy link
Contributor

What is the purpose of the change

Fix port conflict in ServerTransportErrorHandlingTest#testRemoteClose. In the test case, a BindException may be thrown when init Netty server. When initializing Netty server, NetUtils.getAvailablePort() is called in createConfig(). After obtaining the available port, the port may be used by other processes, which may lead to BindException. To resolve the issue, a retry is added when calling initServerAndClient method.

Brief change log

  • Add the number of retries when initializing the Netty server in the test case

Verifying this change

  • Initializing the Netty server successfully in the test case

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7739bb7 (Mon Dec 13 09:25:45 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@TanYuxin-tyx
Copy link
Contributor Author

This is a new PR to resolve the conflicts of release-1.14. The original PR is #17532.

@wsry
Copy link
Contributor

wsry commented Dec 13, 2021

I will help to merge this PR after all tests pass.

wsry pushed a commit that referenced this pull request Dec 13, 2021
@wsry
Copy link
Contributor

wsry commented Dec 14, 2021

Merged.

@wsry wsry closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants