Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-25033][runtime] Let some scheduler components updatable #18102

Closed
wants to merge 3 commits into from
Closed

[FLINK-25033][runtime] Let some scheduler components updatable #18102

wants to merge 3 commits into from

Conversation

wanglijie95
Copy link
Contributor

@wanglijie95 wanglijie95 commented Dec 14, 2021 •
edited

What is the purpose of the change

Let some scheduler components updatable, including DefaultExecutionTopology, SchedulingStrategy, PartitionReleaseStrategy and SlotSharingStrategy.

Brief change log

ca75444 DefaultExecutionTopology supports update.
9294b67 RegionPartitionGroupReleaseStrategy and LocalInputPreferredSlotSharingStrategy support update.

Verifying this change

unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 14, 2021 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5125a3e (Tue Dec 14 09:16:12 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

xiangqiao123
xiangqiao123 reviewed Dec 21, 2021
View reviewed changes
...time/executiongraph/failover/flip1/partitionrelease/RegionPartitionGroupReleaseStrategy.java Outdated
ConsumerRegionGroupExecutionView regionGroup =
new ConsumerRegionGroupExecutionView();
this.consumerRegionGroupExecutionViewMaintainer
.notifyNewRegionGroup(regionGroup);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this moment，regionGroup is a new and empty，call the method notifyNewRegionGroup does not work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it's a bug, I fixed it.

@wanglijie95 wanglijie95 force-pushed the FLINK-25033 branch 2 times, most recently from 114a3c7 to 6ca8ad8 Compare January 16, 2022 14:25
zhuzhurk
zhuzhurk reviewed Jan 17, 2022
View reviewed changes
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java Outdated Show resolved Hide resolved
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java Outdated Show resolved Hide resolved
...apache/flink/runtime/executiongraph/failover/flip1/SchedulingPipelinedRegionComputeUtil.java Outdated Show resolved Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartition.java Outdated Show resolved Hide resolved
...runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartition.java Outdated Show resolved Hide resolved
...ime/src/test/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartitionTest.java Outdated Show resolved Hide resolved
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java Outdated Show resolved Hide resolved
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java Outdated Show resolved Hide resolved
zhuzhurk
zhuzhurk reviewed Jan 18, 2022
View reviewed changes
...time/executiongraph/failover/flip1/partitionrelease/RegionPartitionGroupReleaseStrategy.java Outdated Show resolved Hide resolved
...time/executiongraph/failover/flip1/partitionrelease/RegionPartitionGroupReleaseStrategy.java Show resolved Hide resolved
...ntime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java Outdated Show resolved Hide resolved
...test/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategyTest.java Outdated Show resolved Hide resolved
@wanglijie95
Copy link
Contributor Author

@zhuzhurk Thanks for review. I've addressed all the comments , please help to review it again.

zhuzhurk
zhuzhurk approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments! @wanglijie95
The change now looks good to me.

@zhuzhurk
Copy link
Contributor

Merging.

@zhuzhurk zhuzhurk closed this in 355b165 Jan 20, 2022
@wanglijie95 wanglijie95 deleted the FLINK-25033 branch January 20, 2022 05:30
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
@wanglijie95 @niklassemmler
[FLINK-25033][runtime] RegionPartitionGroupReleaseStrategy and LocalI…
57cbdbd 
…nputPreferredSlotSharingStrategy support update.

This closes apache#18102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangqiao123 xiangqiao123 xiangqiao123 left review comments

@zhuzhurk zhuzhurk zhuzhurk approved these changes

Assignees
No one assigned
Labels
component=Runtime/Coordination
Projects
None yet
Milestone
No milestone
5 participants
@wanglijie95 @flinkbot @zhuzhurk @xiangqiao123 @rmetzger