Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24718][avro] update AVRO dependency to latest version #18133

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

RyanSkraba
Copy link
Contributor

What is the purpose of the change

  • Update AVRO dependency to the latest version

(Continuing on the work of #17623)

Brief change log

  • Updated org.apache.avro:avro:1.10.0 to org.apache.avro:avro:1.11.0

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is already covered by existing tests, such as flink-avro/.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit aa10e52 (Thu Dec 16 12:46:26 UTC 2021)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 16, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@RyanSkraba RyanSkraba marked this pull request as draft December 16, 2021 16:37
@RyanSkraba RyanSkraba force-pushed the rskraba/FLINK-24718-bump-avro branch 2 times, most recently from aa10e52 to ac7b434 Compare December 23, 2021 16:24
@RyanSkraba RyanSkraba force-pushed the rskraba/FLINK-24718-bump-avro branch 2 times, most recently from 635596e to df4f1ac Compare December 27, 2021 13:50
@RyanSkraba RyanSkraba marked this pull request as ready for review December 28, 2021 08:43
@RyanSkraba
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and I would like to get it merged, but I'm not sure if there's a preference to wait for the fix for https://issues.apache.org/jira/browse/AVRO-3273

@fapaul What do you think?

@MartijnVisser
Copy link
Contributor

@zentol I've discussed this briefly with @fapaul but we would like to get your opinion on it.

@zentol
Copy link
Contributor

zentol commented Jan 11, 2022

I'm not really fond of the workaround. Does the avro-maven-plugin actually have to be in sync with the avro version?

@MartijnVisser
Copy link
Contributor

@RyanSkraba Can you elaborate on that?

@RyanSkraba
Copy link
Contributor Author

Hello: it's definitely best practice that the avro-maven-plugin is the same as the avro version. I would recommend waiting for 1.11.1, rather than having avro.version out of sync for the maven plugin!

On the positive side, the workaround is pretty inoffensive -- explicitly specifying a transitive dependency that is only used during the build.

Avro releases about twice a year, but we can ask for a release sooner rather than later as well. I haven't seen other reports from projects that use older versions of Maven.

@MartijnVisser
Copy link
Contributor

@RyanSkraba Since AVRO 1.11.1 is now released, could you update this PR?

@RyanSkraba
Copy link
Contributor Author

I'd love to see this in 1.16! I'm currently with limited connection, but I'll get this updated to 1.11.1 within the week.

@RyanSkraba RyanSkraba force-pushed the rskraba/FLINK-24718-bump-avro branch from 47d686b to 379b0d5 Compare August 4, 2022 05:39
@RyanSkraba
Copy link
Contributor Author

@flinkbot run azure

@eshadei
Copy link

eshadei commented Aug 5, 2022

Hello Team,

Can you please confirm, when we are planning to release Flink 1.16 with Avro 1.11.1?

@RyanSkraba RyanSkraba force-pushed the rskraba/FLINK-24718-bump-avro branch from 379b0d5 to 4abd923 Compare August 8, 2022 12:31
@RyanSkraba
Copy link
Contributor Author

Hello! I've rebased, removed the maven workaround that we needed for 1.11.0 and squashed everything together. There is a CI failure with TPC-DS e2e tests, but I can't seem to determine if it's related!

@zentol
Copy link
Contributor

zentol commented Aug 8, 2022

See FLINK-28789 for the cause of the e2e failure.

+ "\"type_date\": 2014-03-01, \"type_time_millis\": 12:12:12, \"type_time_micros\": 00:00:00.123456, "
+ "\"type_timestamp_millis\": 2014-03-01T12:12:12.321Z, "
+ "\"type_timestamp_micros\": 1970-01-01T00:00:00.123456Z, \"type_decimal_bytes\": \"\\u0007Ð\", "
+ "\"type_date\": \"2014-03-01\", \"type_time_millis\": \"12:12:12\", \"type_time_micros\": \"00:00:00.123456\", "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why these quotes were added? Were they rejected by Avro etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! This was a fix introduced by AVRO-3124, cleaning up the toString() representation to look more like valid JSON.

My personal opinion is that nobody should parse a toString() return value... but it has been useful in testing.

@RyanSkraba
Copy link
Contributor Author

Hello! For info, did this make it to the list for 1.16?

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@MartijnVisser
Copy link
Contributor

Hello! For info, did this make it to the list for 1.16?

Not yet, but perhaps we can still squeeze it in :)

@zentol zentol merged commit c0f0807 into apache:master Aug 31, 2022
@RyanSkraba RyanSkraba deleted the rskraba/FLINK-24718-bump-avro branch March 6, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants