Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][doc] There is a link redirection problem in the Chinese document of Checkpointing #18183

Closed
wants to merge 1 commit into from

Conversation

FlechazoW
Copy link

What is the purpose of the change

There is a link redirection problem in the Chinese document of Checkpointing.
When I wanted to click on the link of 'working with state' in the Chinese document to get more information, the page jumped to 404, but when I checked the English document, I found that turn to correct page. So i fix the link of 'working with state' in the Chinese document.

image

Brief change log

  • Modify the link of 'working with state' in the Chinese document of Checkpointing.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) no

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a green build and then we can approve & get it merged

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 06481b2 (Wed Dec 22 19:27:50 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@FlechazoW
Copy link
Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@FlechazoW
Copy link
Author

Hi, @MartijnVisser I am sorry i just do the wrong thing about 'git rebase'. Now i did it again for 'master' branch. I am sorry for my mistake.

@MartijnVisser
Copy link
Contributor

@WTZ468071157 No worries, we'll see the build pass and then we can approve and get it merged!

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

2 similar comments
@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@FlechazoW
Copy link
Author

Is there any thing wrong with this pr? Is there anything I can do?

@MartijnVisser
Copy link
Contributor

@WTZ468071157 There is an issue with external tests, which causes the build to fail (see https://issues.apache.org/jira/browse/FLINK-25426). We need to retry at this moment unfortunately :(

@MartijnVisser
Copy link
Contributor

@flinkbot run azure

1 similar comment
@MartijnVisser
Copy link
Contributor

@flinkbot run azure

@MartijnVisser
Copy link
Contributor

MartijnVisser commented Dec 27, 2021

@WTZ468071157 Can you please rebase your local branch on master ?

…n checkpointing.md which under content.zh turn to 404 page.
@FlechazoW
Copy link
Author

@MartijnVisser Oh, the ci test success finally! Thank you very much for helping me accomplish this pr.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR!

@fapaul Can you please merge?

@FlechazoW FlechazoW deleted the branch apache:master January 5, 2022 08:21
@FlechazoW FlechazoW closed this Jan 5, 2022
@FlechazoW FlechazoW deleted the master branch January 5, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants