-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][doc] There is a link redirection problem in the Chinese document of Checkpointing #18183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a green build and then we can approve & get it merged
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 06481b2 (Wed Dec 22 19:27:50 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
@flinkbot run azure |
Hi, @MartijnVisser I am sorry i just do the wrong thing about 'git rebase'. Now i did it again for 'master' branch. I am sorry for my mistake. |
@WTZ468071157 No worries, we'll see the build pass and then we can approve and get it merged! |
@flinkbot run azure |
Is there any thing wrong with this pr? Is there anything I can do? |
@WTZ468071157 There is an issue with external tests, which causes the build to fail (see https://issues.apache.org/jira/browse/FLINK-25426). We need to retry at this moment unfortunately :( |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
@WTZ468071157 Can you please rebase your local branch on |
…n checkpointing.md which under content.zh turn to 404 page.
@MartijnVisser Oh, the ci test success finally! Thank you very much for helping me accomplish this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your PR!
@fapaul Can you please merge?
What is the purpose of the change
There is a link redirection problem in the Chinese document of Checkpointing.
When I wanted to click on the link of 'working with state' in the Chinese document to get more information, the page jumped to 404, but when I checked the English document, I found that turn to correct page. So i fix the link of 'working with state' in the Chinese document.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no) noDocumentation