-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][quickstarts] Fix misprints in DataStreamJob.java and DataStreamJob.scala #18184
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2dfdda8 (Wed Dec 22 23:41:25 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
The better the PR is, the higher chance it can be merged quickly. In this case, the PR is not completely following the PR guidelines (as can be found on https://flink.apache.org/contributing/reviewing-prs.html) and the commit message could also be better to meet the Code Style & Quality Guidelines, which can be found at https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html.
@MartijnVisser thanks for you feedback. |
@snuyanzin Could you squash commits from your end? |
1b62110
to
118bdcb
Compare
yes, sure, done |
@snuyanzin Awesome, thank you. I'll wait for the build to turn green and then I'll approve it. |
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. LGTM. @fapaul can you merge it?
What is the purpose of the change
The PR fixes 2 misprints in
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/DataStreamJob.java
and
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/DataStreamJob.scala
begining
=>beginning
fromSequece
=>fromSequence
(The existing method is called
fromSequence
flink/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
Line 1095 in d08a1d0
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: ( no)Documentation