Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][quickstarts] Fix misprints in DataStreamJob.java and DataStreamJob.scala #18184

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Dec 22, 2021

What is the purpose of the change

The PR fixes 2 misprints in
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/DataStreamJob.java
and
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/DataStreamJob.scala

begining => beginning
fromSequece => fromSequence
(The existing method is called fromSequence

)

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2dfdda8 (Wed Dec 22 23:41:25 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

The better the PR is, the higher chance it can be merged quickly. In this case, the PR is not completely following the PR guidelines (as can be found on https://flink.apache.org/contributing/reviewing-prs.html) and the commit message could also be better to meet the Code Style & Quality Guidelines, which can be found at https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html.

@snuyanzin snuyanzin changed the title [hotfix][quickstarts] Misprint fix [hotfix][quickstarts] Fix misprints in DataStreamJob Dec 24, 2021
@snuyanzin snuyanzin changed the title [hotfix][quickstarts] Fix misprints in DataStreamJob [hotfix][quickstarts] Fix misprints in DataStreamJob.java and DataStreamJob.scala Dec 24, 2021
@snuyanzin
Copy link
Contributor Author

@MartijnVisser thanks for you feedback.
I improved the title, description and commit message. Please let me know in case I missed anything.

@MartijnVisser
Copy link
Contributor

@snuyanzin Could you squash commits from your end?

@snuyanzin
Copy link
Contributor Author

yes, sure, done

@MartijnVisser
Copy link
Contributor

@snuyanzin Awesome, thank you. I'll wait for the build to turn green and then I'll approve it.

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@MartijnVisser
Copy link
Contributor

@flinkbot run azure

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM. @fapaul can you merge it?

@fapaul fapaul merged commit 8f44615 into apache:master Jan 10, 2022
@snuyanzin snuyanzin deleted the quickstarts branch May 5, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants