-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings #18343
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 95cf3f8 (Wed Jan 12 16:58:39 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 other surefire configurations, where this also needs to be added.
95cf3f8
to
94936f3
Compare
Thanks for the review @zentol. I've added the missing lines and force pushed an update. PTAL. |
Thanks for the review @zentol. Merging this PR now. |
Actually, I will first re-run the tests. |
This commit sets the locale to en-US in order to avoid ambiguous decimal formattings that can cause the CPUResourceTest to fail.
94936f3
to
1b410df
Compare
This commit sets the locale to en-US in order to avoid ambiguous decimal formattings that can cause the CPUResourceTest to fail. This closes apache#18343.
This commit sets the locale to en-US in order to avoid ambiguous decimal formattings that can cause the CPUResourceTest to fail. This closes apache#18343.
This commit sets the locale to en-US in order to avoid ambiguous decimal formattings that
can cause the CPUResourceTest to fail.