Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24865][CEP] Support MATCH_RECOGNIZE in Batch mode #18408

Closed
wants to merge 2 commits into from
Closed

[FLINK-24865][CEP] Support MATCH_RECOGNIZE in Batch mode #18408

wants to merge 2 commits into from

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Jan 20, 2022

What is the purpose of the change

MATCH_RECOGNIZE only works currently in Streaming mode. It should also be supported in Batch mode.

Brief change log

  • FlinkBatchRuleSets adds the BatchPhysicalMatchRule for the batch rule of the MATCH_RECOGNIZE.
  • Introduces the BatchExecMatch to add the batch ExecNode which matches along with MATCH_RECOGNIZE.

Verifying this change

  • BatchOperatorNameTest adds the testMatch test case for the batch operator of the MATCH_RECOGNIZE.
  • Adds the MatchRecognizeTest and MatchRecognizeValidationTest for the batch mode of the MATCH_RECOGNIZE.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 98deafa (Thu Jan 20 05:24:01 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 20, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser
Copy link
Contributor

@SteNicholas I have to check, let me get back to you asap

@twalthr
Copy link
Contributor

twalthr commented Jan 21, 2022

Thanks for working on this @SteNicholas. I will review it today or Monday latest.

@twalthr twalthr self-assigned this Jan 21, 2022
@lindong28 lindong28 changed the title [FLINK-24865][cep] Support MATCH_RECOGNIZE in Batch mode [FLINK-24865][CEP] Support MATCH_RECOGNIZE in Batch mode Jan 26, 2022
@SteNicholas
Copy link
Member Author

SteNicholas commented Feb 7, 2022

@twalthr @MartijnVisser, could anyone help to review this pull request?

@twalthr
Copy link
Contributor

twalthr commented Feb 14, 2022

@SteNicholas sorry for the delay. The SQL upgrade story still keeps us busy. I guess we have to postpone this to Flink 1.16.

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @SteNicholas, I left some comments and integration testing is missed

@SteNicholas
Copy link
Member Author

SteNicholas commented May 15, 2022

@godfreyhe, I have addressed the above comments and updated this pull request. PTAL.

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I left some comments

@SteNicholas
Copy link
Member Author

@godfreyhe, thanks for your review. I have addressed above comments. PTAL.

@godfreyhe
Copy link
Contributor

Thanks for the update, LGTM

@SteNicholas
Copy link
Member Author

@flinkbot run azure

@godfreyhe godfreyhe closed this in 7f7bee7 Jun 9, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Jun 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants